Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace external image url by base64 encoded image in CSS #14544

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Replace external image url by base64 encoded image in CSS #14544

merged 1 commit into from
Mar 21, 2019

Conversation

youknowriad
Copy link
Contributor

In a WordPress agnostic context, this image might not exist and our packages are supposed to be as generic as possible.

Testing instructions

  • Insert a classic block with a "more" tag and ensure it shows up properly.

@youknowriad youknowriad added [Type] Code Quality Issues or PRs that relate to code quality Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Mar 21, 2019
@youknowriad youknowriad self-assigned this Mar 21, 2019
@youknowriad youknowriad requested a review from draganescu March 21, 2019 07:44
@youknowriad
Copy link
Contributor Author

Thanks for the review @kelin1003

@youknowriad youknowriad merged commit d0a11c9 into master Mar 21, 2019
@youknowriad youknowriad deleted the update/image-css branch March 21, 2019 08:22
@draganescu
Copy link
Contributor

Thanks @youknowriad indeed this the right way :)

@youknowriad youknowriad added this to the 5.4 (Gutenberg) milestone Mar 29, 2019
This was referenced Apr 1, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelin1003 kelin1003 kelin1003 approved these changes

@draganescu draganescu Awaiting requested review from draganescu

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

Assignees

@youknowriad youknowriad

Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
5.4 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
3 participants
@youknowriad @draganescu @kelin1003